Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let metrics libs handle the atomicity #5738

Merged
merged 6 commits into from Feb 11, 2020
Merged

Let metrics libs handle the atomicity #5738

merged 6 commits into from Feb 11, 2020

Commits on Feb 4, 2020

  1. Tune metrics middleware 

    - Let metrics libs handle the atomicity.
- Pre-allocate labels slice so that append() calls do not need to extend it.

Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
    Sylvain Rabot committed Feb 4, 2020
    Configuration menu
    Copy the full SHA
    9fa06c8 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2020

  1. Explain how we init the labels slice 

    Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
    Sylvain Rabot committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    c471560 View commit details
    Browse the repository at this point in the history

  2. Update pkg/middlewares/metrics/metrics.go 

    Co-Authored-By: mpl <mathieu.lonjaret@gmail.com>
    @sylr @mpl
    2 people authored and Sylvain Rabot committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    efb203f View commit details
    Browse the repository at this point in the history

  3. Fix comment 

    Signed-off-by: Sylvain Rabot <s.rabot@lectra.com>
    Sylvain Rabot committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    fd15e24 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2020

  1. review: simplify.

    @ldez
    ldez committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    6fb5928 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into metrics

    Sylvain Rabot committed Feb 11, 2020
    Configuration menu
    Copy the full SHA
    6adbaaf View commit details
    Browse the repository at this point in the history