Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add consul catalog options: requireConsistent, stale, cache #5752

Merged
merged 1 commit into from Oct 31, 2019
Merged

Add consul catalog options: requireConsistent, stale, cache #5752

merged 1 commit into from Oct 31, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Oct 29, 2019

What does this PR do?

Adds consul catalog options:

  • requireConsistent
  • stale
  • cache

Motivation

Closes #5581

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to To review in v2 via automation Oct 29, 2019
@ldez ldez added this to the 2.1 milestone Oct 29, 2019
mmatur
mmatur approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

juliens
juliens approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez @traefiker
feat: add consul catalog options:
e1ab53d 
- requireConsistent
- stale
- cache
@traefiker traefiker merged commit c5ec12c into traefik:master Oct 31, 2019
v2 automation moved this from To review to Done Oct 31, 2019
@ldez ldez deleted the feat/consul-catalog-options branch October 31, 2019 13:11
@ldez ldez changed the title feat: add consul catalog options Add consul catalog options Nov 5, 2019
@ldez ldez changed the title Add consul catalog options Add consul catalog options: requireConsistent, stale, cache Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mmatur mmatur mmatur approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/provider/consulcatalog kind/enhancement a new or improved feature. size/M
Projects
No open projects
v2
Done
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @mmatur @dtomcej @traefiker