Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double dollar on docker-compose config #5775

Merged
merged 1 commit into from Nov 5, 2019
Merged

Double dollar on docker-compose config #5775

merged 1 commit into from Nov 5, 2019

Conversation

clery
Copy link
Contributor

@clery clery commented Nov 5, 2019

What does this PR do?

Add a double dollar sign on docker-compose example, because docker-compose would throw an error like this otherwise:

ERROR: Invalid interpolation format for "labels" option in service "my-service": "traefik.http.middlewares.test-replacepathregex.replacepathregex.regex=/bar/$1"

Motivation

Avoid confusion when starting with Traefik and Docker

More

  • Added/updated documentation

@clery
Double dollar on docker-compose config
e890fe3 
Docker-compose throws an error if using only one dolla
@traefiker traefiker added this to the 2.0 milestone Nov 5, 2019
@ldez ldez added this to To review in v2 via automation Nov 5, 2019
ldez
ldez approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@traefiker traefiker merged commit c37ad5c into traefik:v2.0 Nov 5, 2019
v2 automation moved this from To review to Done Nov 5, 2019
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/documentation area/middleware area/provider/docker size/S
Projects
No open projects
v2
Done
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clery @ldez @traefiker