Add internal provider #5815
Merged
Add internal provider #5815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
kind/enhancement
ldez
force-pushed
the
feature/server-refactor
branch
2 times, most recently
from
1902617
to
366ef9a
Compare
jbdoumenjou
requested changes
Nov 14, 2019
mpl
requested changes
Nov 14, 2019
mpl
requested changes
Nov 14, 2019
mpl
approved these changes
Nov 14, 2019
Co-Authored-By: Jean-Baptiste Doumenjou <jb.doumenjou@gmail.com>
Co-Authored-By: mpl <mathieu.lonjaret@gmail.com>
Co-Authored-By: mpl <mathieu.lonjaret@gmail.com>
traefiker
force-pushed
the
feature/server-refactor
branch
from
d97c1a9
to
2d9266c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Better separation of concerns in the Traefik core.
Split
Serverinto:ConfigurationWatcher: Listens to provider and merges configuration in a configurationTCPEntryPoints: Allows operations on all TCPEntryPoint (start, switch, stop)TCPRouterFactory: Creates the TCP routers per entry point from configurationRemove
RouteAppenderFactory, replaced by the internal provider.Fixes #5374
More
Additional Notes
Co-authored-by: Julien Salleyron julien.salleyron@gmail.com