Fix ACME TOS #582
Merged
Fix ACME TOS #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilevauge
force-pushed
the
fix-acme-tos
branch
from
39d2721
to
02e6259
Compare
| } | ||
| } | ||
| // save account | ||
| err = a.saveAccount(account) |
There was a problem hiding this comment.
We didn't do that before ?
There was a problem hiding this comment.
AgreeToTOS() modifies registration struct. This is not mandatory but now we save it.
|
A small question, but overall LGTM 🐯 |
Signed-off-by: Emile Vauge <emile@vauge.com>
emilevauge
force-pushed
the
fix-acme-tos
branch
from
02e6259
to
b466413
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug with the new Let's Encrypt Terms Of Services.
Fixes #579
Signed-off-by: Emile Vauge emile@vauge.com