Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-acme/lego to 3.2.0 #5839

Merged
merged 3 commits into from Nov 15, 2019
Merged

Conversation

kolaente
Copy link
Contributor

@kolaente kolaente commented Nov 15, 2019

What does this PR do?

Updates go-acme/lego to 3.2.0: https://github.com/go-acme/lego/releases/tag/v3.2.0

Motivation

Fixes bug with:

  • Aurora DNS
  • Cloudflare
  • Digital Ocean
  • OVH

Fixes #5317

Additional:

  • add autodns support.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

I only ran go get -u github.com/go-acme/lego/v3, verified tests are still passing and updated the docs, do I need to do anything else?

@ldez
Copy link
Member

ldez commented Nov 15, 2019

@kolaente could you:

  • rebase the PR on the branch v2.0
git rebase --onto upstream/v2.0 f30a52c2
git push -f
  • run
go mod tidy

@kolaente
Copy link
Contributor Author

@ldez Rebased, but go mod tidy fails with

github.com/containous/traefik/v2/cmd/traefik imports
	github.com/containous/traefik/v2/autogen/genstatic: module github.com/containous/traefik@latest (v1.7.19) found, but does not contain package github.com/containous/traefik/v2/autogen/genstatic

@kolaente
Copy link
Contributor Author

Also, I guess I should target Branch v2.0?

@ldez ldez changed the base branch from master to v2.0 November 15, 2019 10:21
@ldez
Copy link
Member

ldez commented Nov 15, 2019

@kolaente could you:

rm -rf autogen
go generate
go mod tidy

@ldez ldez added this to the 2.0 milestone Nov 15, 2019
@ldez
Copy link
Member

ldez commented Nov 15, 2019

Because of the undocumented and breaking changes made by GitHub, the PR content from a fork by a GitHub organization can no longer be changed by us or by our bot and it's a pain.
Sorry.

@kolaente
Copy link
Contributor Author

Because of the undocumented and breaking changes made by GitHub, the PR content from a fork by a GitHub organization can no longer be changed by us or by our bot and it's a pain.
Sorry.

Sure no problem. I've run your commands, it worked without issues.

@ldez ldez added bot/light-review decreases the number of required LGTM from 3 to 1. and removed contributor/waiting-for-corrections labels Nov 15, 2019
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@traefiker traefiker merged commit 3fd330c into traefik:v2.0 Nov 15, 2019
v2 automation moved this from To review to Done Nov 15, 2019
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Nov 15, 2019
@kolaente kolaente deleted the update/lego branch November 15, 2019 11:07
@dumbFeng

This comment has been minimized.

@dumbFeng

This comment has been minimized.

@kolaente

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants