Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elastic APM tracer implementation #5870

Merged
merged 11 commits into from Nov 27, 2019
Merged

Elastic APM tracer implementation #5870

merged 11 commits into from Nov 27, 2019

Conversation

amine7536
Copy link
Contributor

@amine7536 amine7536 commented Nov 19, 2019 •
edited

What does this PR do?

Adding support for Elastic APM tracing system. https://www.elastic.co/products/apm

Motivation

It is an OpenTracing compatible tracer and we are planning to use it.

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to To review in v2 via automation Nov 20, 2019
@ldez ldez requested a review from mmatur November 20, 2019 08:49
@ldez ldez added the kind/enhancement a new or improved feature. label Nov 20, 2019
@mmatur
Copy link
Member

mmatur commented Nov 25, 2019

Thanks @amine7536 for you contribution

I tested your PR with an example available here, everything works well.

@mmatur mmatur added this to the next milestone Nov 25, 2019
mmatur
mmatur approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.
LGTM

ldez
ldez approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@traefik traefik deleted a comment from jbdoumenjou Nov 27, 2019
@traefik traefik deleted a comment from jbdoumenjou Nov 27, 2019
@traefik traefik deleted a comment from jbdoumenjou Nov 27, 2019
jbdoumenjou
jbdoumenjou approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit fe8b090 into traefik:master Nov 27, 2019
v2 automation moved this from To review to Done Nov 27, 2019
@amine7536 amine7536 deleted the feat-elastic-apm branch November 27, 2019 15:39
@amine7536
Copy link
Contributor Author

Hi, thanks for the approval.
Keep up the good work, Traefik is awesome 💪.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/middleware/tracing kind/enhancement a new or improved feature. size/L
Projects
No open projects
v2
Done
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@amine7536 @mmatur @jbdoumenjou @ldez @traefiker