New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Swarm section to the Docker Provider Documentation #5874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a few comments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a quick pass about english/typoes. I haven't given any thought about the document's structure and contents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…specific sections for docker itself Signed-off-by: dduportal <1522731+dduportal@users.noreply.github.com>
Signed-off-by: dduportal <1522731+dduportal@users.noreply.github.com>
Co-Authored-By: Daniel Tomcej <daniel.tomcej@gmail.com>
Co-Authored-By: mpl <mathieu.lonjaret@gmail.com>
What does this PR do?
This PR aims at adding a Swarm section in the Docker provider documentation,
introducing the following changes:
Motivation
More
[ ] Added/updated testsAdditional Notes