Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sub command help #5887

Merged
merged 1 commit into from Nov 27, 2019
Merged

fix: sub command help #5887

merged 1 commit into from Nov 27, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Nov 23, 2019 •
edited

What does this PR do?

sub command help

Motivation

before:

$ ./cmd test subtest subsubtest --help
command test error: command not found: subtest

after:

$ ./cmd test subtest subsubtest --help
subsubtest    

Usage: subsubtest [command] [flags] [arguments]

Use "subsubtest [command] --help" for help on any command.

Commands:
    subsubsubtest

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to the 2.1 milestone Nov 23, 2019
@ldez ldez added this to To review in v2 via automation Nov 23, 2019
dtomcej
dtomcej approved these changes Nov 24, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

juliens
juliens approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou
jbdoumenjou approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 772b260 into traefik:v2.1 Nov 27, 2019
v2 automation moved this from To review to Done Nov 27, 2019
@ldez ldez deleted the fix/subcommand-help branch November 27, 2019 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@Ullaakut Ullaakut Ullaakut approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/cli kind/bug/fix a bug fix size/M
Projects
No open projects
v2
Done
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ldez @juliens @jbdoumenjou @Ullaakut @dtomcej @traefiker