Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Request Headers CORS Preflight Requirement #5903

Merged
merged 1 commit into from Nov 28, 2019

Conversation

dtomcej
Copy link
Contributor

@dtomcej dtomcej commented Nov 27, 2019

What does this PR do?

This PR Removes the Access-Control-Request-Headers requirement for determining if the request is a Preflight or not.

Motivation

Fixes #5896

More

  • Added/updated tests
  • Added/updated documentation - None needed, bugfix

Additional Notes

The W3 cors documentation leaves much to be desired:
https://www.w3.org/TR/cors/#cross-origin-request-with-preflight-0

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants