Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consul catalog constraints. #5913

Merged
merged 2 commits into from Nov 29, 2019

Conversation

ldez
Copy link
Member

@ldez ldez commented Nov 29, 2019

What does this PR do?

Consul catalog constraints by using tags instead of labels.

Motivation

Be able to use all kind of tags as constraints.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Closes #5911

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez force-pushed the fix/consul-catalog-constraints branch from 142831b to e60511f Compare November 29, 2019 14:51
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the fix/consul-catalog-constraints branch from e60511f to a1b24c6 Compare November 29, 2019 16:00
@traefiker traefiker merged commit cf1ace3 into traefik:v2.1 Nov 29, 2019
v2 automation moved this from To review to Done Nov 29, 2019
@ldez ldez deleted the fix/consul-catalog-constraints branch November 29, 2019 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants