Improve documentation on file provider limitations with file system notifications #5939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbdoumenjou
added
kind/enhancement
dtomcej
suggested changes
Dec 4, 2019
jbdoumenjou
force-pushed
the
fix/file-provider-limitations
branch
from
e1d87a5
to
564b8c5
Compare
dtomcej
approved these changes
Dec 4, 2019
mmatur
force-pushed
the
fix/file-provider-limitations
branch
3 times, most recently
from
73b7b8b
to
8e8da36
Compare
Co-Authored-By: Daniel Tomcej <daniel.tomcej@gmail.com>
traefiker
force-pushed
the
fix/file-provider-limitations
branch
from
8e8da36
to
9ede11b
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Exposes the limitations of the file provider with file system notifications and update the documentation examples accordingly.
Motivation
Sometime, the dynamic configuration is not updated on file changes.
After some tests, we can deduce that according to the configuration, it may be:
So, the issue does not come from Traefik, but from the file systems, the orchestrators and the fsnotify library. That's why we improve the Traefik documentation.
Close #5589
More
Added/updated tests