Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrent map writes error #5962

Closed
wants to merge 1 commit into from

Conversation

dsseng
Copy link
Contributor

@dsseng dsseng commented Dec 8, 2019

What does this PR do?

Fix #5953 error and prevent similar issues in accesslog in future

Motivation

Fixes #5953

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@dsseng

This comment has been minimized.

@mpl
Copy link
Collaborator

mpl commented Dec 9, 2019

Hi @sh7dm ,

First off, thank you for this PR.

We understand why you want to add a mutex, and that would have been my first reaction. However, we would like to avoid that as it should not be needed, because there should not be any concurrent access of the log, and we'd rather fix the origin of the issue. Also, we're concerned that adding a mutex would hide other concurrent accesses that we missed and that we would like to fix.
Which is why we did this other PR instead for now:

#5967

We're going to leave your PR open for a while, in case it turns out we still need it.

@dsseng
Copy link
Contributor Author

dsseng commented Dec 9, 2019

okay, you're right.

@ldez
Copy link
Member

ldez commented Dec 10, 2019

as the user in #5953 confirm that the problem is fixed by #5967, I will close this PR.

Thank you anyway 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants