Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix weighted service provider icon #5983

Merged
merged 2 commits into from Dec 10, 2019
Merged

Fix weighted service provider icon #5983

merged 2 commits into from Dec 10, 2019

Conversation

dsseng
Copy link
Contributor

@dsseng dsseng commented Dec 10, 2019

What does this PR do?

Fix weighted service provider icon that was incorrect (undefined.png)

Motivation

Fix #5813

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@traefiker traefiker added this to the 2.0 milestone Dec 10, 2019
@ldez ldez added this to To review in v2 via automation Dec 10, 2019
@ldez ldez changed the base branch from v2.0 to v2.1 December 10, 2019 10:07
@ldez ldez modified the milestones: 2.0, 2.1 Dec 10, 2019
ldez
ldez approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@dsseng
Copy link
Contributor Author

dsseng commented Dec 10, 2019

No problem! I'm glad to work with Traefik!

paulocfjunior
paulocfjunior approved these changes Dec 10, 2019
View reviewed changes
Copy link

@paulocfjunior paulocfjunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😉

jbdoumenjou
jbdoumenjou approved these changes Dec 10, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 1b6c7af into traefik:v2.1 Dec 10, 2019
v2 automation moved this from To review to Done Dec 10, 2019
@traefiker traefiker mentioned this pull request Dec 10, 2019
Closed
@dsseng dsseng deleted the weighted-icon branch December 10, 2019 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpl mpl mpl approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@ldez ldez ldez approved these changes

@paulocfjunior paulocfjunior paulocfjunior approved these changes

Assignees
No one assigned
Labels
area/webui kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dsseng @mpl @jbdoumenjou @ldez @paulocfjunior @traefiker