Use valid condition in the service details panel UI #5984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
changed the title
mpl
reviewed
Dec 10, 2019
| @@ -54,7 +54,7 @@ | |||
| </div> | |||
| </q-card-section> | |||
|
|
|||
| <q-card-section v-if="data.loadBalancer.terminationDelay"> | |||
| <q-card-section v-if="data.loadBalancer && data.loadBalancer.terminationDelay"> | |||
There was a problem hiding this comment.
data itself is never nil? i.e., is there no need for:
"data && data.loadBalancer && data.loadBalancer.terminationDelay"
?
mpl
approved these changes
Dec 10, 2019
traefiker
added
bot/merge-retry-1
status/4-merge-in-progress
and removed
bot/merge-retry-1
labels
…service details panel
traefiker
force-pushed
the
fix/ui-service-detail-panel
branch
from
45dbe9a
to
6713356
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use valid condition for the termination delay section in the service details panel.
Motivation
Have a working service detail panel.
More
Added/updated testsAdded/updated documentation