Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework access control origin configuration #5996

Merged
merged 13 commits into from Mar 5, 2020
Merged

Rework access control origin configuration #5996

merged 13 commits into from Mar 5, 2020

Conversation

dtomcej
Copy link
Contributor

@dtomcej dtomcej commented Dec 10, 2019 •
edited

What does this PR do?

This PR:

  • Updates the behavior of the header middleware in regards to access-control-origin.
  • Updates the documentation to provide more configuration examples and provides links to our source material

Motivation

Fixes #5994
Fixes #5567

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to To review in v2 via automation Dec 10, 2019
@dduportal dduportal mentioned this pull request Dec 12, 2019
Closed
@helloIAmPau

This comment has been minimized.

Sign in to view
@ldez ldez added this to the next milestone Dec 18, 2019
@dtomcej dtomcej mentioned this pull request Dec 18, 2019
Closed
2 tasks
juliens
juliens requested changes Dec 19, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't be breaking

docs/content/middlewares/headers.md Outdated Show resolved Hide resolved
@almassapargali

This comment has been minimized.

Sign in to view
@dtomcej dtomcej mentioned this pull request Jan 20, 2020
Closed
2 tasks
@nadilas

This comment has been minimized.

Sign in to view
@dtomcej dtomcej requested review from ldez and juliens January 28, 2020 09:30
@meabed

This comment has been minimized.

Sign in to view
ldez
ldez reviewed Mar 4, 2020
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou
jbdoumenjou approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 082fb16 into traefik:master Mar 5, 2020
v2 automation moved this from To review to Done Mar 5, 2020
@alt4 alt4 mentioned this pull request Apr 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/middleware kind/enhancement a new or improved feature. size/S
Projects
No open projects
v2
Done
Milestone
2.2
9 participants
@dtomcej @helloIAmPau @almassapargali @nadilas @meabed @juliens @jbdoumenjou @ldez @traefiker