Restore ExternalName https support for Kubernetes CRD #6037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
kind/bug/fix
mpl
approved these changes
Dec 16, 2019
ldez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Kubernetes CRD was missing support for ExternalName https backends. It's already added into v2.0 and Kubernetes Ingress in v2.1 has it already included, so, I simply add this into CRDs.
Motivation
I need Sticky sessions with Kubernetes CRDs and ExternalName on https backends in an ongoing project, and this feature is going to be implemented anyway.
I made the former pull request to support https backends in ExternalNames for v2.0, as they were hardcoded as "http" backends in the code.
More
Additional Notes
Related to #5660
Regression from #5711