Add ratelimit headers. #6111
Add ratelimit headers. #6111
Conversation
ioggstream
force-pushed
the
add-ratelimit-headers
branch
from
b572047
to
148e3c3
Compare
ldez
added
kind/enhancement
|
Of note: The draft was updated and renewed in March 2020: https://tools.ietf.org/html/draft-polli-ratelimit-headers-02 |
Yep! I linked 3scale and kong merge commits too. I need some help to finish this implementation @dtomcej can you provide some guidance? |
|
Hi @dtomcej , the ratelimit draft recently landed on Envoy too envoyproxy/envoy#12410 Do you have any feedback for implementing it into traefik and reorganize this PR? |
|
@ioggstream Thank you for your interest in Traefik and for the draft PR. Given the RFC you've mentioned is still in draft state, the team here would prefer to wait until the RFC is accepted, alternatively if there is a large consensus of Traefik users who would like this feature implemented before the acceptance of the RFC draft we would revisit the topic. In the meantime, it is possible to create custom plugins using Traefik Pilot in the 2.3RC - you can read more about how to build your own. |
|
@ioggstream The team has decided to close this PR, in the future we'll consider the PR once the specification has been recommended or enough users have requested this functionality exist on the official rate limit middleware. Feel free to keep the issue open in the meantime and let us know when the RFC has come out of the draft state. Thank you again for the contribution, and we're looking forward to the custom plugin demonstrating this capability. |
|
@notsureifkevin thanks for your time :) I will take a look at the custom plugin features, but it will take some time. In case you were going to add ratelimit headers Ratelimit middleware, I just suggest reading the I-D https://tools.ietf.org/html/draft-polli-ratelimit-headers-02 first :D Have a nice day, R. |
What does this PR do?
Stub implementation of https://tools.ietf.org/html/draft-polli-ratelimit-headers-03
Motivation
Avoid clients receiving 429 abruptly
Fixes #6113
More
Additional Notes
Other implementors: Kong, 3scale ,
Envoy, Express Gateway PR.