Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memleak in safe.Pool #6140

Merged
merged 7 commits into from
Jan 20, 2020
Merged

fix memleak in safe.Pool #6140

merged 7 commits into from
Jan 20, 2020
+8 −109

Commits on Jan 20, 2020

  1. do not use unbounded routinepool for requests 

    safe.Pool is not a pool in the usual sense as it is not bounded and
it keeps on appending new goroutines, instead of reusing a limited
number of goroutines. Moreover, even when a goroutine is done, there's
still a small footprint of it, as there is a reference to it that was
appended in a slice, and that never gets removed.

For this reason, it should not be used in places where potentially lots
of go routines are generated, such as in the mirroring service, where
there's one go routine per incoming request.

Fixes traefik#6125
    @mpl @traefiker
    mpl authored and traefiker committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    e55bade View commit details
    Browse the repository at this point in the history

  2. fix safe.Pool memleak by removing footprint of goroutines after use

    @mpl @traefiker
    mpl authored and traefiker committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    11fcce1 View commit details
    Browse the repository at this point in the history

  3. Fix the pool of routines with chan too while we're at it

    @mpl @traefiker
    mpl authored and traefiker committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    6c48e0a View commit details
    Browse the repository at this point in the history

  4. Remove routinectx slice because it's use only by Start which is not u… 

    …sed anymore
    @juliens @traefiker
    juliens authored and traefiker committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    86aa9ac View commit details
    Browse the repository at this point in the history

  5. Remove unused Start

    @juliens @traefiker
    juliens authored and traefiker committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    d06feb5 View commit details
    Browse the repository at this point in the history

  6. remove tests that used Start

    @mpl @traefiker
    mpl authored and traefiker committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    8e6feb1 View commit details
    Browse the repository at this point in the history

  7. remove unused addGo

    @mpl @traefiker
    mpl authored and traefiker committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    2503fe5 View commit details
    Browse the repository at this point in the history