Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ingress annotations support #6160

Merged
merged 4 commits into from Jan 14, 2020
Merged

Add Ingress annotations support #6160

merged 4 commits into from Jan 14, 2020

Conversation

ldez
Copy link
Member

@ldez ldez commented Jan 13, 2020

What does this PR do?

Add Ingress annotations support.

Motivation

Fixes #6074

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Co-authored-by: jbdoumenjou jb.doumenjou@gmail.com

@ldez ldez added this to To review in v2 via automation Jan 13, 2020
@ldez ldez added this to the next milestone Jan 13, 2020
@ldez ldez force-pushed the feat/ingress-annotations branch 2 times, most recently from b229e43 to 4492e49 Compare January 13, 2020 11:16
jbdoumenjou
jbdoumenjou approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

SantoDE
SantoDE approved these changes Jan 14, 2020
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👼

awesome job!

@traefiker traefiker merged commit 6b7be46 into traefik:master Jan 14, 2020
v2 automation moved this from To review to Done Jan 14, 2020
@ldez ldez deleted the feat/ingress-annotations branch January 14, 2020 14:58
This was referenced Jan 18, 2020
Open
Closed
@travisghansen travisghansen mentioned this pull request Mar 8, 2020
Closed
@jimmykarily jimmykarily mentioned this pull request Feb 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@SantoDE SantoDE SantoDE approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/ingress area/provider/k8s kind/enhancement a new or improved feature. size/L
Projects
No open projects
v2
Done
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

Improvements of the Ingress Support in Traefik v2
5 participants
@ldez @jbdoumenjou @SantoDE @mmatur @traefiker