fix: etcd provider name. #6212
Merged
fix: etcd provider name. #6212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
status/2-needs-review
area/provider/etcd
kind/bug/fix
ldez
force-pushed
the
fix/etcd-provider-name
branch
from
ffb7126
to
97bc8e4
Compare
traefiker
force-pushed
the
fix/etcd-provider-name
branch
from
97bc8e4
to
4e058a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use the provider name instead of the store name as concrete provider name.
https://github.com/abronan/valkeyrie/blob/1ae9442de16e0751c9bcc51fdb1c8300bf4fa835/store/store.go#L18
Motivation
Fixes #6209
More
[ ] Added/updated tests[ ] Added/updated documentation