Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement of the certificates resolvers logs #6225

Merged
merged 2 commits into from Jan 24, 2020
Merged

Improvement of the certificates resolvers logs #6225

merged 2 commits into from Jan 24, 2020

Conversation

ldez
Copy link
Member

@ldez ldez commented Jan 23, 2020

What does this PR do?

Improvement if the certificates resolvers logs

Motivation

Have a clear error message.

More

  • [ ] Added/updated tests
  • [ ] Added/updated documentation

@ldez ldez added this to To review in v2 via automation Jan 23, 2020
@traefiker traefiker added this to the 2.1 milestone Jan 23, 2020
@ldez ldez changed the title Improvement if the certificates resolvers logs Improvement of the certificates resolvers logs Jan 23, 2020
jbdoumenjou
jbdoumenjou approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 87044c5 into traefik:v2.1 Jan 24, 2020
v2 automation moved this from To review to Done Jan 24, 2020
@ldez ldez deleted the fix/acme-logs branch January 24, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mpl mpl mpl approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

Assignees
No one assigned
Labels
area/acme area/logs kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @mpl @jbdoumenjou @traefiker