Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update valkeyrie to fix the support of Redis. #6291

Merged
merged 2 commits into from Feb 10, 2020
Merged

Update valkeyrie to fix the support of Redis. #6291

merged 2 commits into from Feb 10, 2020

Conversation

ldez
Copy link
Member

@ldez ldez commented Feb 7, 2020

What does this PR do?

Update valkeyrie to fix the support of Redis.

Motivation

Fixes #6210

More

  • [ ] Added/updated tests
  • [ ] Added/updated documentation

@ldez ldez added this to the next milestone Feb 7, 2020
@ldez ldez added this to To review in v2 via automation Feb 7, 2020
juliens
juliens approved these changes Feb 8, 2020
View reviewed changes
Copy link
Member

@juliens juliens left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
CI is failing 😕

@ldez ldez removed the bot/no-merge label Feb 8, 2020
dtomcej
dtomcej approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker merged commit ea2d65f into traefik:master Feb 10, 2020
v2 automation moved this from To review to Done Feb 10, 2020
@ldez ldez deleted the fix/redis branch February 10, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mpl mpl mpl approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/provider/kv area/provider/redis kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

Redis provider is not working
5 participants
@ldez @juliens @mpl @dtomcej @traefiker