Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package management with Glide #63

Merged
merged 2 commits into from Oct 13, 2015
Merged

Update package management with Glide #63

merged 2 commits into from Oct 13, 2015

Conversation

@emilevauge
Copy link
Member

@emilevauge emilevauge commented Oct 13, 2015

No more Godep!!!
Please welcome Glide :)
This resolves https://github.com/EmileVauge/traefik/issues/35

@emilevauge emilevauge force-pushed the no-more-godep-ever branch from 645884b to 743e446 Oct 13, 2015
@ldez
Copy link
Member

@ldez ldez commented Oct 13, 2015

mj-side-glide-o


COPY . /go/src/github.com/emilevauge/traefik

ENV GOPATH /go
Copy link
Contributor

@vdemeester vdemeester Oct 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this is needed (should be set by the parent image golang)

Copy link
Member Author

@emilevauge emilevauge Oct 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, corrected

@emilevauge emilevauge force-pushed the no-more-godep-ever branch 4 times, most recently from df1599c to 93b28eb Oct 13, 2015
@vdemeester
Copy link
Contributor

@vdemeester vdemeester commented Oct 13, 2015

friends-ross-do-the-dance

@vdemeester
Copy link
Contributor

@vdemeester vdemeester commented Oct 13, 2015

By the way, looks good, seems good, works good so LGTM 🐹.

vdemeester added a commit that referenced this issue Oct 13, 2015
Update package management with Glide
@vdemeester vdemeester merged commit 37438a6 into master Oct 13, 2015
1 check passed
@vdemeester vdemeester deleted the no-more-godep-ever branch Oct 13, 2015
timoreimann pushed a commit to timoreimann/traefik that referenced this issue Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants