Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dashboard example with k8s CRD. #6330

Merged
merged 1 commit into from Feb 17, 2020
Merged

fix: dashboard example with k8s CRD. #6330

merged 1 commit into from Feb 17, 2020

Conversation

ldez
Copy link
Member

@ldez ldez commented Feb 17, 2020

What does this PR do?

dashboard example with k8s CRD.

Motivation

Have a better documentation.

More

  • [ ] Added/updated tests
  • Added/updated documentation

@ldez ldez added this to To review in v2 via automation Feb 17, 2020
@traefiker traefiker added this to the 2.1 milestone Feb 17, 2020
juliens
juliens approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou
jbdoumenjou approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SantoDE
SantoDE approved these changes Feb 17, 2020
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 76bb2ef into traefik:v2.1 Feb 17, 2020
v2 automation moved this from To review to Done Feb 17, 2020
@ldez ldez deleted the fix/doc-k8s-dashboard branch February 17, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@SantoDE SantoDE SantoDE approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/k8s/crd size/S
Projects
No open projects
v2
Done
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @jbdoumenjou @SantoDE @traefiker