Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in the godoc of TLS option MaxVersion #6347

Merged
merged 1 commit into from Feb 21, 2020
Merged

Fix typo in the godoc of TLS option MaxVersion #6347

merged 1 commit into from Feb 21, 2020

Conversation

pschaub
Copy link
Contributor

@pschaub pschaub commented Feb 20, 2020 •
edited

What does this PR do?

Fix a typo.

@ldez ldez changed the base branch from master to v2.1 February 20, 2020 20:50
@ldez ldez changed the title Fix typo in tls certificate MaxVersion Fix typo in the godoc of TLS option MaxVersion Feb 20, 2020
@ldez ldez added this to To review in v2 via automation Feb 20, 2020
@ldez ldez added this to the 2.1 milestone Feb 20, 2020
ldez
ldez approved these changes Feb 20, 2020
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SantoDE
SantoDE approved these changes Feb 21, 2020
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@traefiker traefiker merged commit e04ebaa into traefik:v2.1 Feb 21, 2020
v2 automation moved this from To review to Done Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@SantoDE SantoDE SantoDE approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/documentation area/tls kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pschaub @juliens @SantoDE @ldez @traefiker