Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch healthcheck only one time instead of two #6372

Merged
merged 1 commit into from Feb 25, 2020

Conversation

juliens
Copy link
Member

@juliens juliens commented Feb 25, 2020

What does this PR do?

Healthcheck was launch two times at each configuration refresh, and it can create some side effect. Now the healthcheck is launch only one time at each configuration refresh.

Motivation

Fixes #6096

@traefiker traefiker added this to the 2.1 milestone Feb 25, 2020
@ldez ldez added this to To review in v2 via automation Feb 25, 2020
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 1e7f34c into traefik:v2.1 Feb 25, 2020
v2 automation moved this from To review to Done Feb 25, 2020
@ldez ldez changed the title Launch healhcheck only one time instead of two Launch healthcheck only one time instead of two Feb 28, 2020
@juliens juliens deleted the fix-healthcheck branch April 23, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants