Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go-acme/lego to v3.4.0 #6376

Merged
merged 3 commits into from Feb 26, 2020
Merged

Update go-acme/lego to v3.4.0 #6376

merged 3 commits into from Feb 26, 2020

Conversation

ldez
Copy link
Member

@ldez ldez commented Feb 25, 2020

What does this PR do?

Motivation

Fixes:

  • [dnsprovider] zoneee: fix subdomains.
  • [dnsprovider] designate: Don't clean up managed records like SOA and NS
  • [dnsprovider] dnspod: update lib.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

  • [dnsprovider] Add DNS provider for Constellix
  • [dnsprovider] Add DNS provider for Servercow.
  • [dnsprovider] Add DNS provider for Scaleway

@ldez ldez added status/2-needs-review area/acme kind/bug/fix a bug fix bot/light-review decreases the number of required LGTM from 3 to 1. labels Feb 25, 2020
@ldez ldez added this to To review in v2 via automation Feb 25, 2020
@traefiker traefiker added this to the 2.1 milestone Feb 25, 2020
juliens
juliens approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 54df7b0 into traefik:v2.1 Feb 26, 2020
v2 automation moved this from To review to Done Feb 26, 2020
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Feb 26, 2020
@ldez ldez deleted the fix/update-lego branch February 26, 2020 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/acme kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ldez @juliens @traefiker