Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Allow fsnotify to reload config files on k8s (or symlinks)" #6416

Merged
merged 1 commit into from Mar 3, 2020
Merged

Revert "Allow fsnotify to reload config files on k8s (or symlinks)" #6416

merged 1 commit into from Mar 3, 2020

Conversation

juliens
Copy link
Member

@juliens juliens commented Mar 3, 2020

What does this PR do?

This PR revert the PR #5037

Motivation

The PR #5037 generates error messaging:

ERRO[2020-03-02T23:22:35+01:00] Could not remove watcher for /home/juliens/test: can't remove non-existent inotify watch for: /home/juliens/test/4913  providerName=file
ERRO[2020-03-02T23:23:09+01:00] Could not remove watcher for /home/juliens/test: can't remove non-existent inotify watch for: /home/juliens/test/4913  providerName=file

Additional Notes

We need to think more about a solution to handle this.

jbdoumenjou
jbdoumenjou approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldez
ldez approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added this to To review in v2 via automation Mar 3, 2020
@ldez ldez added this to the 2.2 milestone Mar 3, 2020
@traefiker traefiker merged commit 67e17de into traefik:master Mar 3, 2020
v2 automation moved this from To review to Done Mar 3, 2020
@juliens juliens deleted the revert-fsnotify branch April 23, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/provider/file kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@juliens @jbdoumenjou @mmatur @ldez @traefiker