Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the k8s CRD documentation #6426

Merged
merged 4 commits into from Mar 5, 2020
Merged

Update the k8s CRD documentation #6426

merged 4 commits into from Mar 5, 2020

Conversation

jbdoumenjou
Copy link
Member

What does this PR do?

Update the CRD documentation:

  • Update RBAC reference with the TLSStores resource
  • Use the CRD and RBAC definitions in the user guide
  • Update the migration guide with the new CRDs

Motivation

Have up-to-date documentation

More

  • Added/updated tests
  • Added/updated documentation

@jbdoumenjou jbdoumenjou added this to To review in v2 via automation Mar 4, 2020
@jbdoumenjou jbdoumenjou added this to the 2.2 milestone Mar 4, 2020
ldez
ldez approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SantoDE
SantoDE approved these changes Mar 5, 2020
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 93a7af2 into traefik:master Mar 5, 2020
v2 automation moved this from To review to Done Mar 5, 2020
@jbdoumenjou jbdoumenjou deleted the doc/crd-tlsstore branch March 5, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@SantoDE SantoDE SantoDE approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/k8s/crd area/provider/k8s size/M
Projects
No open projects
v2
Done
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jbdoumenjou @juliens @SantoDE @ldez @traefiker