Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve kubernetes external name service support #6428

Merged
merged 6 commits into from Mar 10, 2020
Merged

Improve kubernetes external name service support #6428

merged 6 commits into from Mar 10, 2020

Conversation

rtribotte
Copy link
Member

What does this PR do?

Improve kubernetes external name service support by allowing three ways to define port for backends

Motivation

fixes #6390

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Co-authored-by: jbdoumenjou jb.doumenjou@gmail.com

@jbdoumenjou jbdoumenjou added this to To review in v2 via automation Mar 5, 2020
@jbdoumenjou jbdoumenjou added this to the 2.2 milestone Mar 5, 2020
@jbdoumenjou jbdoumenjou added the kind/enhancement a new or improved feature. label Mar 5, 2020
@jbdoumenjou jbdoumenjou force-pushed the fix/6390-external-name-service branch from 7c72c10 to 8a783b4 Compare March 5, 2020 15:08
@rtribotte rtribotte force-pushed the fix/6390-external-name-service branch from 8a783b4 to 79a59fe Compare March 6, 2020 10:42
@jbdoumenjou jbdoumenjou changed the base branch from master to v2.2 March 6, 2020 10:49
jbdoumenjou
jbdoumenjou approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added kind/bug/fix a bug fix and removed kind/enhancement a new or improved feature. labels Mar 9, 2020
dtomcej
dtomcej previously approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@dtomcej dtomcej self-requested a review March 9, 2020 16:21
juliens
juliens approved these changes Mar 9, 2020
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej reviewed Mar 9, 2020
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small feedback

docs/content/routing/providers/kubernetes-crd.md Outdated Show resolved Hide resolved
docs/content/routing/providers/kubernetes-crd.md Outdated Show resolved Hide resolved
@dtomcej dtomcej dismissed their stale review March 9, 2020 17:33

Further changes after review

dtomcej
dtomcej approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@ldez ldez self-requested a review March 10, 2020 01:15
@ldez ldez removed the bot/no-merge label Mar 10, 2020
ldez
ldez approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the fix/6390-external-name-service branch from 7b14c96 to 3dbde29 Compare March 10, 2020 11:22
@traefiker traefiker merged commit 3b85dc9 into traefik:v2.2 Mar 10, 2020
v2 automation moved this from To review to Done Mar 10, 2020
@traefiker traefiker mentioned this pull request Mar 10, 2020
Closed
@rtribotte rtribotte deleted the fix/6390-external-name-service branch March 11, 2020 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@ldez ldez ldez approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/crd area/provider/k8s kind/bug/fix a bug fix size/L
Projects
No open projects
v2
Done
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

IngressRouteTCP object not created when the route is a Service of type ExternalName
6 participants
@rtribotte @juliens @jbdoumenjou @ldez @dtomcej @traefiker