Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify passthrough for TCP/TLS in its own section #6459

Merged
merged 3 commits into from Mar 10, 2020
Merged

Specify passthrough for TCP/TLS in its own section #6459

merged 3 commits into from Mar 10, 2020

Conversation

mpl
Copy link
Collaborator

@mpl mpl commented Mar 9, 2020

What does this PR do?

This PR reworks a bit the documentation, to move the passthrough option in its own section.

Motivation

Perfectionism.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@mpl mpl added this to the 2.2 milestone Mar 9, 2020
@mpl mpl added this to To review in v2 via automation Mar 9, 2020
dtomcej
dtomcej approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

jbdoumenjou
jbdoumenjou approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldez
ldez approved these changes Mar 10, 2020
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 4408c63 into traefik:v2.2 Mar 10, 2020
v2 automation moved this from To review to Done Mar 10, 2020
@mpl mpl deleted the tcp-passthrough branch April 13, 2022 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@ldez ldez ldez approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/documentation area/tcp area/tls kind/enhancement a new or improved feature. size/S
Projects
No open projects
v2
Done
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mpl @jbdoumenjou @ldez @dtomcej @traefiker