Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop traefik from default entry points. #6477

Merged
merged 1 commit into from Mar 16, 2020
Merged

Drop traefik from default entry points. #6477

merged 1 commit into from Mar 16, 2020

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 13, 2020 •
edited by mpl

What does this PR do?

Drop traefik from default entry points.

Motivation

The entry point named traefik is an internal entry point, so it should not be applied by default.

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to To review in v2 via automation Mar 13, 2020
@traefiker traefiker added this to the 2.2 milestone Mar 13, 2020
@ldez ldez changed the title Drop traefik from default entry point. Drop traefik from default entry points. Mar 13, 2020
jbdoumenjou
jbdoumenjou approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the fix/default-entrypoints-traefik branch from 5dec777 to ab316c3 Compare March 16, 2020 14:52
@traefiker traefiker merged commit af58faa into traefik:v2.2 Mar 16, 2020
v2 automation moved this from To review to Done Mar 16, 2020
@ldez ldez deleted the fix/default-entrypoints-traefik branch March 16, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@mpl mpl mpl approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

Assignees
No one assigned
Labels
area/server kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @juliens @mpl @jbdoumenjou @traefiker