Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: terminology, replace 'encoded' by 'hashed' #6478

Merged
merged 1 commit into from Mar 13, 2020

Conversation

debovema
Copy link
Contributor

What does this PR do?

Fix cryptographic-related terminology in documentation.

Motivation

The term 'encoded' for passwords being hashed (by MD5, SHA1 or BCrypt) is wrong and can be misleading.

More

  • Added/updated tests
  • Added/updated documentation

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ldez ldez added this to To review in v2 via automation Mar 13, 2020
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 672234a into traefik:v2.2 Mar 13, 2020
v2 automation moved this from To review to Done Mar 13, 2020
@debovema debovema deleted the doc-fix-crypto-terminology branch March 13, 2020 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants