Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix entry point redirect behavior #6512

Merged
merged 4 commits into from Mar 18, 2020
Merged

Fix entry point redirect behavior #6512

merged 4 commits into from Mar 18, 2020

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 18, 2020

What does this PR do?

Allows to :

  • set permanent to false.
  • set priority
  • use a port instead of entry point name.

Motivation

Fixes #6474

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@ldez ldez added this to To review in v2 via automation Mar 18, 2020
@traefiker traefiker added this to the 2.2 milestone Mar 18, 2020
dtomcej
dtomcej approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

mmatur
mmatur approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou
jbdoumenjou approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mpl
mpl approved these changes Mar 18, 2020
View reviewed changes
pkg/provider/traefik/internal.go Outdated Show resolved Hide resolved
docs/content/routing/entrypoints.md Outdated Show resolved Hide resolved
mpl
mpl requested changes Mar 18, 2020
View reviewed changes
Copy link
Collaborator

@mpl mpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I messed up before and did not want to approve

@ldez ldez removed the bot/no-merge label Mar 18, 2020
@traefiker traefiker merged commit 44221fb into traefik:v2.2 Mar 18, 2020
v2 automation moved this from To review to Done Mar 18, 2020
@traefiker traefiker mentioned this pull request Mar 18, 2020
Closed
@ldez ldez deleted the fix/permanent-redirect branch March 18, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpl mpl mpl approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@mmatur mmatur mmatur approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/provider/internal kind/bug/fix a bug fix size/M
Projects
No open projects
v2
Done
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ldez @mpl @jbdoumenjou @mmatur @dtomcej @traefiker