Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in metrics #6522

Merged
merged 2 commits into from Mar 19, 2020
Merged

Fix memory leak in metrics #6522

merged 2 commits into from Mar 19, 2020

Conversation

juliens
Copy link
Member

@juliens juliens commented Mar 19, 2020 •
edited by ldez

What does this PR do?

Fix a memory leak in metrics.

Motivation

Fixes #6520

More

  • Added/updated tests
    - [ ] Added/updated documentation

Co-authored-by: Ludovic Fernandez ldez@users.noreply.github.com

@traefiker traefiker added this to the 2.1 milestone Mar 19, 2020
@ldez ldez added this to To review in v2 via automation Mar 19, 2020
ldez
ldez approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added the priority/P0 needs hot fix label Mar 19, 2020
@ldez ldez mentioned this pull request Mar 19, 2020
Closed
jbdoumenjou
jbdoumenjou approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit b40fa61 into traefik:v2.1 Mar 19, 2020
v2 automation moved this from To review to Done Mar 19, 2020
@ldez ldez deleted the fix-memory-leak branch March 19, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/middleware/metrics area/middleware kind/bug/fix a bug fix priority/P0 needs hot fix size/S
Projects
No open projects
v2
Done
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@juliens @jbdoumenjou @mmatur @ldez @traefiker