Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the default priority on the router created by the redirect. #6588

Merged
merged 1 commit into from Mar 30, 2020
Merged

Change the default priority on the router created by the redirect. #6588

merged 1 commit into from Mar 30, 2020

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 26, 2020

What does this PR do?

Change the default priority on the router created by the redirect.

Motivation

Have a better default behavior.

More

  • [ ] Added/updated tests
  • [ ] Added/updated documentation

@ldez ldez added this to To review in v2 via automation Mar 26, 2020
@traefiker traefiker added this to the 2.2 milestone Mar 26, 2020
@ldez ldez changed the title fix: default to max priority. Change the default priority on the router created by the redirect. Mar 26, 2020
jbdoumenjou
jbdoumenjou approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SantoDE
SantoDE approved these changes Mar 26, 2020
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM x)

dtomcej
dtomcej approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker merged commit a6b6e1d into traefik:v2.2 Mar 30, 2020
v2 automation moved this from To review to Done Mar 30, 2020
@ldez ldez deleted the fix/redirect-priority branch March 30, 2020 12:56
@ldez ldez mentioned this pull request Apr 8, 2020
Closed
@ldez ldez mentioned this pull request Apr 28, 2020
Closed
@ekarlso ekarlso mentioned this pull request May 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@SantoDE SantoDE SantoDE approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/provider/internal kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ldez @jbdoumenjou @SantoDE @dtomcej @traefiker