Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add polling for getOverview in toolbar #6611

Merged
merged 1 commit into from Apr 27, 2020
Merged

Add polling for getOverview in toolbar #6611

merged 1 commit into from Apr 27, 2020

Conversation

lukashass
Copy link
Contributor

What does this PR do?

Fix #6610 by polling getOverview in the toolbar.

Motivation

Up to date numbers

More

  • [ ] Added/updated tests
  • [ ] Added/updated documentation

@traefiker traefiker added this to the 2.2 milestone Mar 31, 2020
@ldez ldez requested a review from matthieuh March 31, 2020 23:43
@ldez ldez added this to To review in v2 via automation Mar 31, 2020
matthieuh
matthieuh approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@matthieuh matthieuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and thank you for the contribution 👍

SantoDE
SantoDE approved these changes Apr 27, 2020
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 2f18e20 into traefik:v2.2 Apr 27, 2020
v2 automation moved this from To review to Done Apr 27, 2020
@traefiker traefiker mentioned this pull request Apr 27, 2020
Closed
@lukashass lukashass deleted the toolbar-overview-polling branch April 11, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpl mpl mpl approved these changes

@SantoDE SantoDE SantoDE approved these changes

@matthieuh matthieuh matthieuh approved these changes

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
area/webui kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@lukashass @mpl @SantoDE @matthieuh @mmatur @ldez @traefiker