Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about health check in kubernetes #6647

Merged
merged 2 commits into from Apr 7, 2020

Conversation

mmatur
Copy link
Member

@mmatur mmatur commented Apr 7, 2020

What does this PR do?

This PR adds a note about the health check in kubernetes

Motivation

Have a clear documentation

More

  • [ ] Added/updated tests
  • Added/updated documentation

@mmatur mmatur added this to the 2.2 milestone Apr 7, 2020
@ldez ldez added status/2-needs-review kind/enhancement a new or improved feature. and removed kind/enhancement a new or improved feature. status/0-needs-triage labels Apr 7, 2020
@ldez ldez added this to To review in v2 via automation Apr 7, 2020
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@traefiker traefiker merged commit 148400a into traefik:v2.2 Apr 7, 2020
v2 automation moved this from To review to Done Apr 7, 2020
!!! warning "Health check in Kubernetes"

The Traefik health check is not available for `kubernetesCRD` and `kubernetesIngress` providers because Kubernetes
has already an health check mecanism.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
has already an health check mecanism.
already has a health check mechanism.

@@ -106,13 +106,13 @@ HTTP configuration.
Default middlewares for the routers linked to the entry point.

`TRAEFIK_ENTRYPOINTS_<NAME>_HTTP_REDIRECTIONS_ENTRYPOINT_PERMANENT`:
Applied a permanent redirection. Defaults to true. (Default: ```true```)
Applied a permanent redirection. (Default: ```true```)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Applied a permanent redirection. (Default: ```true```)
Applies a permanent redirection. (Default: ```true```)

Permanent bool `description:"Applied a permanent redirection. Defaults to true." json:"permanent,omitempty" toml:"permanent,omitempty" yaml:"permanent,omitempty"`
Priority int `description:"Priority of the generated router. Defaults to 1." json:"priority,omitempty" toml:"priority,omitempty" yaml:"priority,omitempty"`
Scheme string `description:"Scheme used for the redirection." json:"https,omitempty" toml:"https,omitempty" yaml:"https,omitempty"`
Permanent bool `description:"Applied a permanent redirection." json:"permanent,omitempty" toml:"permanent,omitempty" yaml:"permanent,omitempty"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Permanent bool `description:"Applied a permanent redirection." json:"permanent,omitempty" toml:"permanent,omitempty" yaml:"permanent,omitempty"`
Permanent bool `description:"Applies a permanent redirection." json:"permanent,omitempty" toml:"permanent,omitempty" yaml:"permanent,omitempty"`

@mmatur mmatur deleted the feature/kubernetes-crd-healt-check branch January 21, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants