Allows multi-level KV prefixes #6664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
area/provider/kv
kind/enhancement
niki-timofe
force-pushed
the
fix/kv-prefixes
branch
from
d9b9827
to
87bb1bd
Compare
|
It is possible to review and merge this PR? Will be helpful for us using Zookeeper as backend config store |
ldez
added
status/2-needs-review
bot/no-merge
and removed
status/1-needs-design-review
labels
ldez
force-pushed
the
fix/kv-prefixes
branch
2 times, most recently
from
30151ca
to
1be56ac
Compare
ldez
approved these changes
Aug 6, 2020
traefiker
force-pushed
the
fix/kv-prefixes
branch
from
61c7e7b
to
744e395
Compare
|
I can't see this in the latest release: v2.2.11. Any chance of seeing it soon? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows slashes in root key of KV-storages.
Motivation
We've got single KV storage shared across many of teams. Each team have its own directory in it. My team soon to have some separated Traefiks. So it would be cool, if we can separate configurations as:
There is no information about inadmissibility of slashes neither in documentation nor in logs, only message: "invalid root label". I see two possibilities of resolving this situation: add this constraint to documentation or add this feature.
As it's technically not too complex to implement, I chose 2nd variant.
More