Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update headers.md #6675

Merged
merged 1 commit into from Apr 14, 2020
Merged

Update headers.md #6675

merged 1 commit into from Apr 14, 2020

Conversation

jamct
Copy link
Contributor

@jamct jamct commented Apr 13, 2020

What does this PR do?

This PR adds details in documentation for accessControlMaxAge (CORS Header).

Motivation

I had to look up this information at mozilla.org.

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

add details for `accessControlMaxAge`. Value in seconds.
@traefiker traefiker merged commit 619bc95 into traefik:v2.2 Apr 14, 2020
v2 automation moved this from To review to Done Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v2
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants