Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: consider UDP when checking for empty config #6683

Merged
merged 1 commit into from Apr 16, 2020
Merged

fix: consider UDP when checking for empty config #6683

merged 1 commit into from Apr 16, 2020

Conversation

nrwiersma
Copy link
Contributor

What does this PR do?

This PR considers UDP when checking for an empty configuration in the configuration watcher.

Motivation

Allow UDP only dynamic configurations.

Additional Notes

@traefiker traefiker added this to the 2.2 milestone Apr 16, 2020
@ldez ldez added this to To review in v2 via automation Apr 16, 2020
juliens
juliens approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ldez
ldez approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou
jbdoumenjou approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 2171cb7 into traefik:v2.2 Apr 16, 2020
v2 automation moved this from To review to Done Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/udp kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nrwiersma @juliens @jbdoumenjou @ldez @traefiker