ratelimit: do not default to ipstrategy too early #6713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
adding no merge because current test does not actually prevent regression for now. |
ldez
added
status/2-needs-review
contributor/waiting-for-corrections
and removed
bot/no-merge
status/0-needs-triage
labels
after consideration, I don't think the regression should be prevented in the unit tests of the ratelimiter package, since SetDefaults is applied out of this package. However, I'm wondering if we should enforce that the fields of SourceCriterion are all mutually exclusive (they already actually are), and in which case we could add a test reflecting that property. |
And we already take care of setting ipstrategy as the default in the rate limiter constructor anyway. Fixes traefik#6687
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes ipstrategy being systematically set as the default source
criterion, which was causing any other source criterion provided in the config
to be ignored.
We already take care of setting ipstrategy as the default in the rate limiter
constructor anyway.
Motivation
Fixes #6687
More
[ ] Added/updated documentationAdditional Notes