Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sentence about the resource namespace and middleware #6719

Merged
merged 4 commits into from Apr 27, 2020
Merged

Add sentence about the resource namespace and middleware #6719

merged 4 commits into from Apr 27, 2020

Conversation

SantoDE
Copy link
Collaborator

@SantoDE SantoDE commented Apr 22, 2020 •
edited by ldez

What does this PR do?

Adds a sentence about the fact, that the namespace of a middleware is internally added automatically, as it's important when you want to reference that middleware from another provider.

Motivation

Enhance our Docs

Fix #6318

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@SantoDE SantoDE changed the title Add sentence about that the ressource namespace is automatically appe… Add sentence about that the ressource namespace Apr 22, 2020
@SantoDE SantoDE force-pushed the enhance_documentation_reference_crd_middleware branch from 5b7ddfa to 6ad6372 Compare April 22, 2020 14:26
@SantoDE SantoDE changed the base branch from master to v2.2 April 22, 2020 14:26
@ldez ldez added the kind/enhancement a new or improved feature. label Apr 22, 2020
kevtainer
kevtainer suggested changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@kevtainer kevtainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this suggestion, I found a minor spelling issue with Resource in both cases. Please update Ressource in the ressource-name to the correct spelling resource

kevtainer
kevtainer reviewed Apr 22, 2020
View reviewed changes
Copy link
Contributor

@kevtainer kevtainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SantoDE @mpl the most recent commit appears to have a change in the indentation but not the actual spelling.

kevtainer
kevtainer suggested changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@kevtainer kevtainer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust spacing and correct spelling of resource

@SantoDE
Copy link
Collaborator Author

SantoDE commented Apr 23, 2020

Should be done @notsureifkevin

ldez
ldez approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SantoDE SantoDE mentioned this pull request Apr 23, 2020
Closed
@ldez ldez added this to To review in v2 via automation Apr 23, 2020
@ldez ldez added this to the 2.2 milestone Apr 23, 2020
@ldez ldez changed the title Add sentence about that the ressource namespace Add sentence about the resource namespace Apr 24, 2020
@ldez ldez changed the title Add sentence about the resource namespace Add sentence about the resource namespace and middleware Apr 24, 2020
@traefiker traefiker force-pushed the enhance_documentation_reference_crd_middleware branch from 9bb6397 to efda45f Compare April 27, 2020 09:24
@traefiker traefiker merged commit 4fcf7bf into traefik:v2.2 Apr 27, 2020
v2 automation moved this from To review to Done Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpl mpl mpl approved these changes

@mmatur mmatur mmatur approved these changes

@kevtainer kevtainer kevtainer approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/k8s kind/enhancement a new or improved feature. size/S
Projects
No open projects
v2
Done
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SantoDE @mpl @mmatur @kevtainer @ldez @traefiker