Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix KV service docs for http:url and tcp:address #6720

Merged
merged 4 commits into from Apr 27, 2020
Merged

fix KV service docs for http:url and tcp:address #6720

merged 4 commits into from Apr 27, 2020

Conversation

bryfry
Copy link
Contributor

@bryfry bryfry commented Apr 22, 2020

What does this PR do?

Fix what looks like a copy-paste error in the KV services documentation.

Motivation

  • HTTP service currently shows schema instead of a url service destination
  • TCP service currently shows an http schema

@traefiker traefiker added this to the 2.2 milestone Apr 22, 2020
@ldez ldez added this to To review in v2 via automation Apr 22, 2020
ldez
ldez approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

SantoDE
SantoDE approved these changes Apr 27, 2020
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@traefiker traefiker merged commit 367e797 into traefik:v2.2 Apr 27, 2020
v2 automation moved this from To review to Done Apr 27, 2020
@bryfry bryfry deleted the patch-2 branch April 28, 2020 21:24
bryfry
bryfry commented Apr 28, 2020
View reviewed changes
Copy link
Contributor Author

@bryfry bryfry left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ldez Looks like this change added some erroneous -----'s to the Value header

728a540#diff-b01c75154055b034cd4c747683f5fe53R109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SantoDE SantoDE SantoDE approved these changes

@mmatur mmatur mmatur approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/kv kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bryfry @SantoDE @mmatur @ldez @traefiker