Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix healthcheck.interval in docs #6847

Merged
merged 1 commit into from May 26, 2020
Merged

Fix healthcheck.interval in docs #6847

merged 1 commit into from May 26, 2020

Conversation

OndrejIT
Copy link
Contributor

What does this PR do?

Fixing "time: missing unit in duration 10"
Because this feature used time.ParseDuration library .

Motivation

:-)

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpl
Copy link
Collaborator

mpl commented May 26, 2020

As a doc fix, I think this should be merged against the latest branch (v2.2).

@dtomcej dtomcej changed the base branch from master to v2.2 May 26, 2020 16:21
Fix" time: missing unit in duration 10"
Because this feature used time.ParseDuration library .
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@dtomcej dtomcej added this to the 2.2 milestone May 26, 2020
@traefiker traefiker merged commit 8c5846c into traefik:v2.2 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants