Fix ipv6 handling in redirect middleware #6902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we may also update the regexp in https://github.com/containous/traefik/blob/v2.2/pkg/provider/traefik/internal.go#L200 with something like |
|
@jbdoumenjou I agree, i applied your suggestion, thanks. |
rtribotte
force-pushed
the
fix/5197-ipv6-redirect
branch
2 times, most recently
from
930843f
to
594b8bd
Compare
traefiker
force-pushed
the
fix/5197-ipv6-redirect
branch
from
594b8bd
to
ce05c10
Compare
ldez
force-pushed
the
fix/5197-ipv6-redirect
branch
from
ce05c10
to
1195864
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the regex used by redirect middleware to handle properly ipv6 in urls
Fixes #5197
Motivation
See #5197
More
Added/updated documentationAdditional Notes