Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log field names in documentation #6952

Merged
merged 1 commit into from Jul 1, 2020
Merged

Fix log field names in documentation #6952

merged 1 commit into from Jul 1, 2020

Conversation

gysel
Copy link
Contributor

@gysel gysel commented Jun 23, 2020

What does this PR do?

Fixes incorrect JSON log field names in the documentation.
I aligned the table with the keys defined in pkg/middlewares/accesslog/logdata.go.

@traefiker traefiker added this to the 2.2 milestone Jun 23, 2020
@gysel gysel changed the title Fixed log field names in documentation Fix log field names in documentation Jun 23, 2020
ldez
ldez approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ldez ldez added the kind/bug/fix a bug fix label Jul 1, 2020
juliens
juliens approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez added this to To review in v2 via automation Jul 1, 2020
jbdoumenjou
jbdoumenjou approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit cc4879f into traefik:v2.2 Jul 1, 2020
v2 automation moved this from To review to Done Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliens juliens juliens approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/documentation kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gysel @juliens @jbdoumenjou @ldez @mpl @traefiker