Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update go-acme/lego to v3.8.0 #6988

Merged
merged 1 commit into from Jul 2, 2020
Merged

Update go-acme/lego to v3.8.0 #6988

merged 1 commit into from Jul 2, 2020

Conversation

ldez
Copy link
Member

@ldez ldez commented Jul 2, 2020

What does this PR do?

Update go-acme/lego to v3.8.0

Motivation

Fixes:

  • [dnsprovider] stackpath: fix subdomain support.
  • [dnsprovider] arvandcloud: fix record name.
  • [dnsprovider] fix: multi-va.
  • [dnsprovider] constellix: fix search records API call.
  • [dnsprovider] hetzner: fix record name.
  • [lib] Registrar.ResolveAccountByKey: Fix malformed request

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

  • [dnsprovider] inwx: Two-Factor-Authentication
  • [dnsprovider] Add DNS provider for ArvanCloud

@ldez ldez added status/2-needs-review area/acme kind/bug/fix a bug fix bot/light-review decreases the number of required LGTM from 3 to 1. labels Jul 2, 2020
@ldez ldez added this to To review in v2 via automation Jul 2, 2020
@ldez ldez added this to the 2.2 milestone Jul 2, 2020
jbdoumenjou
jbdoumenjou approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 3350b56 into traefik:v2.2 Jul 2, 2020
v2 automation moved this from To review to Done Jul 2, 2020
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Jul 2, 2020
@ldez ldez deleted the fix/update-lego branch July 2, 2020 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

Assignees
No one assigned
Labels
area/acme kind/bug/fix a bug fix
Projects
No open projects
v2
Done
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ldez @jbdoumenjou @traefiker