Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic when using chain middleware. #7016

Merged
merged 1 commit into from Jul 9, 2020
Merged

Fix panic when using chain middleware. #7016

merged 1 commit into from Jul 9, 2020

Conversation

juliens
Copy link
Member

@juliens juliens commented Jul 9, 2020

What does this PR do?

Fixes #7014

Motivation

No more panic!

More

  • Added/updated tests
    - [ ] Added/updated documentation

@traefiker traefiker added this to the 2.2 milestone Jul 9, 2020
@ldez ldez added this to To review in v2 via automation Jul 9, 2020
SantoDE
SantoDE approved these changes Jul 9, 2020
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

ldez
ldez approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou
jbdoumenjou approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit b10cb84 into traefik:v2.2 Jul 9, 2020
v2 automation moved this from To review to Done Jul 9, 2020
@traefiker traefiker mentioned this pull request Jul 9, 2020
Closed
@ldez ldez mentioned this pull request Jul 9, 2020
Closed
@ldez ldez deleted the fix-panic-chain branch July 9, 2020 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@SantoDE SantoDE SantoDE approved these changes

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
area/middleware kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@juliens @jbdoumenjou @SantoDE @ldez @traefiker